Document custom controls #2278
Merged
Document custom controls #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * and then adding this to the map. | ||
| * | ||
| * The advantages of having this as a control rather than a simple separate DOM | ||
| * element are that things like zIndex and preventing propagation are handled |
There was a problem hiding this comment.
I don't think the lib applies any zIndex'ing to controls.
There was a problem hiding this comment.
I'm just quoting what @fredj said on the list https://groups.google.com/d/msg/ol3-dev/LnN3IUNxtoM/nxXZ3_Nmh1EJ
I can remove that if it's not correct
|
ok. Unwanted bits removed. |
|
Looks fine to me. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on the list https://groups.google.com/d/msg/ol3-dev/LnN3IUNxtoM/K0glKxDU8nUJ