Fix the closure-compiler and closure-library versions #2283
Conversation
|
Looks good to me. |
|
@fredj, have you actually verified that ol compiles with these versions of the Closure compiler and library? If so then please merge. |
|
Also, this PR does not seem to be inline with what @tschaub is suggesting in openlayers/closure-util#14 (comment). @tschaub is suggesting to update closure-util to the most recent versions of the Closure Compiler and Library, and update ol3 to the latest closure-util. Any reason for doing otherwise? To me it makes more sense to do as Tim suggested, because in this way ol3 uses the versions of the Compiler and the Library against which closure-util is tested. And it's only if ol3 doesn't work with the latest versions of the Closure Compiler and Library that we add a closure-util.json file with specific versions to ol3. Does it make sense? |
|
The library version is the same as the version provided with Plovr, the compiler version is the latest one. I will make a PR to closure-util to update the compiler and library version as Tim suggested but we will still need to set the library version in ol |
|
PR updated, do not merge until closure 0.18.0 is released @elemoine is that what you had in mind? |
The version is the same as the one provided by plovr-81ed862.jar
|
It looks good to me. I now understand why we need a closure-util.json file in ol3 – the ol3 code is currently not compatible with the latest version of Closure Library. |
Fix the closure-compiler and closure-library versions
|
It's not clear to me why we wouldn't also peg the Compiler version here. |
it would be good to document exactly what is not compatible |
See openlayers/closure-util#14 (comment)