Mark the color argument to ol.color.transform non-nullable #2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inside this function goog.vec.Mat4.multVec3 is called and and its arguments must not be null.
|
Nice. Please merge. |
|
Are there more things we need to do to be compatible with the recent versions of the Closure library? |
|
We can also remove the local copy of |
|
Looks good. Removing our copy of |
fredj
added a commit
that referenced
this pull request
Jul 2, 2014
Mark the color argument to ol.color.transform non-nullable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside this function
goog.vec.Mat4.multVec3is called and and its arguments must not be null (with recent version of the google closure library).This PR and #2284 make the code base compatible with the latest version of the google closure library.