Document map DOM elements #2355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -258,7 +258,8 @@ olx.OverlayOptions.prototype.positioning; | |||
| /** | |||
| * Whether event propagation to the map viewport should be stopped. Default is | |||
| * `true`. If `true` the overlay is placed in the same container as that of the | |||
| * controls (`ol-overlaycontainer-stopevent`). | |||
| * controls (`ol-overlaycontainer-stopevent`); if `false` it is placed in | |||
| * `ol.overlaycontainer`. | |||
There was a problem hiding this comment.
Should this be ol-overlaycontainer instead? I think it might be clearer to say something about this being a CSS class name. Maybe "if false, it is placed in an element that lets events pass through (with class ol-overlaycontainer)" or something.
There was a problem hiding this comment.
yes, you're right. I'll change this
|
updated to clarify that the names are CSS class names |
|
Good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently various references to the 'map viewport' and to overlaycontainers, but no description of what/where these are.