-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples to ol.coordinate functions #2425
Conversation
* Example: | ||
* | ||
* var coord = [7.85, 47.983333]; | ||
* var otherCoord = ol.coordinate.add(coord, [-2, 4]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be tempted to skip the return here (though your comment below clarifies, it risks misinterpretation since it is named otherCoord
).
var coord = [-180, 45];
ol.coordinate.add(coord, [360, -90]);
// coord is now [180, -45]
Nice @marcjansen! One comment on In any case, merge when ready. |
Thanks for the review Tim. I'll change the mentioned parts and then merge. |
@marcjansen You can use |
@ahocevar Which will affect way more commit then this needs. I think I will simply create a new branch with the changes applied via a |
That worked fine, I'll merge once Travis is done. |
Add examples to ol.coordinate functions
Title says it all.