Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand docs for color options #2465

Merged
merged 1 commit into from Aug 18, 2014
Merged

Expand docs for color options #2465

merged 1 commit into from Aug 18, 2014

Conversation

probins
Copy link
Contributor

@probins probins commented Jul 29, 2014

partly based on #1985 (comment)

@@ -1,3 +1,8 @@
/**
* Colors can be defined as a {@link ol.Color} array, or as strings in
* `rgb(r,g,b)` or `rgba(r,g,b,a)` format, or in hex `#xxxxxx` or `#xxx` format.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be #rrggbb instead of #xxxxxx and #rgb instead of #xxx (?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, yes

@probins
Copy link
Contributor Author

probins commented Aug 18, 2014

any reason why this can't be merged?

@elemoine
Copy link
Member

any reason why this can't be merged?

Yes, a rebase is required :-)

@probins
Copy link
Contributor Author

probins commented Aug 18, 2014

hm, and conflicting with another of my PRs too :-(

should now be mergeable

elemoine pushed a commit that referenced this pull request Aug 18, 2014
Expand docs for color options
@elemoine elemoine merged commit 8f7f814 into openlayers:master Aug 18, 2014
@probins probins deleted the color branch August 18, 2014 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants