-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug fix to play nice with sencha touch 2.3 #2501
Conversation
Are you experimenting the same issue without sencha? eg. http://ol3js.org/en/master/examples/mobile-full-screen.html This is weird; the |
Sencha touch is probably building or changing the |
Yes that's it, I've seen this in the past as well. |
PR attached, please review |
|
@tsauerwein ok, thanks for the info |
+1 as long as using |
Yes it's the same: "You may also use standard array syntax to access items in the list." |
Are you experimenting the same issue without sencha? Fix quickly promoted in the main branch, nice job! |
bug fix to play nice with sencha touch 2.3
We have included ol3 map in a sencha touch 2.3 mobile application. Within the mobile app, the map crash as soon as we click on it. We have been able to pin point the problem (and do a dummy fix) with the ol-whitespace.js file.
OL3 version: 3.0.0-beta.5
File: ol-whitespace.js
Line: 25856
var touch = event.changedTouches.item(0);
replaced by
var touch = event.changedTouches[0];
No more crash, the click event is now propagated successfully to the sencha app handlers.