Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move createDefaultEditingStyles() to ol.style #2513

Merged
merged 1 commit into from
Aug 18, 2014
Merged

Move createDefaultEditingStyles() to ol.style #2513

merged 1 commit into from
Aug 18, 2014

Conversation

probins
Copy link
Contributor

@probins probins commented Aug 11, 2014

Fixes #2440. I think this is all that's needed.

@elemoine elemoine added this to the v3.0.0 milestone Aug 11, 2014
@probins
Copy link
Contributor Author

probins commented Aug 11, 2014

I got this to compile by copying what was done in #2394: make everything require ol.style.Style. But this surely isn't correct. ISTM style/style.js should be providing either ol.style as a namespace for the static functions, or the functions themselves, such as ol.style.StyleFunction.

@elemoine
Copy link
Member

@probins based on your last comment I am not sure this PR is ready for review or not. Could you please clarify things?

@probins
Copy link
Contributor Author

probins commented Aug 18, 2014

it's ready for review, and should work as #2394 does. But there's a broader issue of what style/style.js should be providing (goog.provide). That's a separate issue though.

@elemoine
Copy link
Member

It looks good to me. @tonio, do you agree with this patch as well?

@tonio
Copy link
Member

tonio commented Aug 18, 2014

+1, thanks!

tonio added a commit that referenced this pull request Aug 18, 2014
Move createDefaultEditingStyles() to ol.style
@tonio tonio merged commit 139ea4c into openlayers:master Aug 18, 2014
@probins probins deleted the editstyle branch August 18, 2014 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default style and default editing style should be in same file
3 participants