Return rather than fail if resolution is not defined #2527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be included in 3.0? |
|
Looks good to me. Please merge. |
pagameba
added a commit
that referenced
this pull request
Aug 16, 2014
Return rather than fail if resolution is not defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a source which has to parse data, it is possible for the source to
changebefore the map has calledloadFeatures, triggering the assertion in debug mode and failing entirely otherwise. This proposes to remove the assertion and simply return ifresolution_is not defined.An alternate approach I considered was to delay registering for the
changeevent on the origin source until the first time loadFeatures is called, but this seemed simpler and safer.