Support for "Stateless GetFeatureInfo" #2582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit follows up on #2348.
|
Tested on desktop & mobile, with ≠ pixelRatio and with rotation, looks like it works great. |
|
Same here on a nexus 5 (pixel ratio of 3) |
|
Thanks! Please tell me if you have any comments on the code. |
elemoine
pushed a commit
that referenced
this pull request
Aug 21, 2014
Support for "Stateless GetFeatureInfo"
|
A late post-merge +1 and Thank You for this! |
|
Thanks. Adding that capability actually simplified and sanitized the code significantly. It's rarely the case, so worth mentioning :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the "stateless GetFeatureInfo" approach as discussed in #2117.
With this patch
getGetFeatureInfoUrlreturns a URL even though there's no rendered layer for the WMS source. So it's now possible to display an OSM layer and use a non-rendered WMS source (with no corresponding layer) just for GetFeatureInfo.Can be tested on http://erilem.net/ol3/wmsgfi/examples/getfeatureinfo-image.html and http://erilem.net/ol3/wmsgfi/examples/getfeatureinfo-tile.html. I'm particularly interested in tests in devices with pixel ratios greater than 1.
Closes #2117.
Please test and review.