Making ol.Overlay accept offset values if positioning right or bottom #2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ol.Overlay has set positioning is set to right or bottom, no offset is applied. I added the missing calculations. I made 2 fiddles showing the bahaviour before and after. The divs in hte fiddles are named after their positioning (anchor point)! Not the actual position! Before: http://jsfiddle.net/simon_seyock/ob7ggtx6/ As you can see, on div named "bottom-right" no offset at all is applied. On "bottom-center" it is only applied horizontally and on "center-right" only vertically. After: http://jsfiddle.net/simon_seyock/sL2f3nL9/2/ All offsets are applied correctly, you could draw a straight line through the anchor points of every div.
|
LGTM. Anyone opposed to get this in for 3.0 ? |
|
no objection from me @tonio |
|
thanks @bartvde |
tonio
added a commit
that referenced
this pull request
Aug 27, 2014
Making ol.Overlay accept offset values if positioning right or bottom
|
and thanks for the patch @simonseyock (-: |
|
@simonseyock, I don't think we have a CLA from you? Could you please sign it? See https://github.com/openlayers/cla/blob/master/README.md. The procedure is pretty straightforward. Thanks. |
|
It's on the way. 2014-08-27 11:04 GMT+02:00 Éric Lemoine notifications@github.com:
|
|
CCLA received. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ol.Overlay has set positioning is set to right or bottom, no offset is applied. I added the missing calculations.
I made 2 fiddles showing the bahaviour before and after.
The divs in the fiddles are named after their positioning (anchor point)! Not the actual position!
Before: http://jsfiddle.net/simon_seyock/ob7ggtx6/
As you can see, on div named "bottom-right" no offset at all is applied. On "bottom-center" it is only applied horizontally and on "center-right" only vertically.
After: http://jsfiddle.net/simon_seyock/sL2f3nL9/2/
All offsets are applied correctly, you could draw a straight line through the anchor points of every div.