Handle interfaces in the generate-externs task #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| }); | ||
|
|
||
| }; |
ahocevar
force-pushed
the
interface-externs
branch
from
d34f86c
to
e560f52
Compare
| @@ -28,6 +28,7 @@ exports.publish = function(data, opts) { | |||
| [ | |||
| {define: {isObject: true}}, | |||
| {api: {isString: true}}, | |||
| {'interface': {is: true}}, | |||
There was a problem hiding this comment.
/me discovered that interface is a reserved keyword.
ahocevar
force-pushed
the
interface-externs
branch
from
16b98df
to
e560f52
Compare
|
Is this good to merge? When merged, it will be easier to fix the remaining issues in #2644. |
|
I'm fine with this, as long as it does not break the doc generation. |
|
This does not affect the doc generation at all. |
ahocevar
added a commit
that referenced
this pull request
Aug 28, 2014
Handle interfaces in the generate-externs task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2615.