Possibility to restrict the type of features you can select #3277

acanimal · 2015-02-25T19:59:36Z

See #3257 issue.

This PR includes samples and also an initial implementation based on a new filter property which accepts a ol.interaction.SelectFilterFunction invoked for each selected feature and that determines if the feature must be selected or not.

elemoine · 2015-02-25T20:30:58Z

src/ol/interaction/selectinteraction.js

+   * @private
+   * @type {ol.interaction.SelectFilterFunction}
+   */
+  this.filter_ = goog.isDef(options.filter) ? options.filter : null;


The new filter option needs to be added to olx.interaction.SelectOptions. See the externs/olx.js file.

You could change this to:

this.filter_ = goog.isDef(options.filter) ? options.filter : goog.functions.TRUE;

and thereby avoid testing that this.filter_ is defined in the handleEvent function.

Nice tip. I just start reading "Closure the definite guide".

… the SelectFilterFunction

elemoine · 2015-02-25T22:04:32Z

src/ol/interaction/selectinteraction.js

@@ -150,7 +167,9 @@ ol.interaction.Select.handleEvent = function(mapBrowserEvent) {
         * @param {ol.layer.Layer} layer Layer.
         */
        function(feature, layer) {
-          selected.push(feature);
+          if (goog.isFunction(filter) && filter(feature, layer)) {


You don't need the isFunction test.

acanimal · 2015-02-25T22:07:45Z

Updated PR with the @elemoine comments. Added documentation to the olx.js file too.

Although the ./build.py ci task runs fine I don't know why the apidoc doesn't show the new filter property.

In addition, I have added a second parameter to the ol.interaction.SelectFilterFunction that references the layers which feature belongs. By some comment on the list I think having a reference to the layer can help in some situations.

elemoine · 2015-02-25T22:08:17Z

examples/select-features-with-filter.js

+    if (types === null) {
+      return true;
+    } else {
+      return goog.array.contains(types, feature.getGeometry().getType());


You can't use goog functions in ol3 examples.

Changed to use indexOf.

elemoine · 2015-02-25T22:10:37Z

@acanimal, I don't think we need a new example for that new option.

elemoine · 2015-02-25T22:14:34Z

externs/olx.js

+/**
+ * A function that takes an {@link ol.Feature} and an {ol.layer.Layer} and
+ * returns true if the feature may be selected or false otherwise.
+ * @typedef {function(ol.Feature, ol.layer.Layer): boolean}


@typedef - > @type. And why don't you use ol.interaction.SelectFilterFunction here too?

We don't have a typedef for the layer filter so I think I'd drop the typedef entirely.

Sorry, mistake copy&paste. Now apidoc is generated fine.

acanimal · 2015-02-25T22:44:11Z

I think sample can help to show how to use the property. Anyway the property is so trivial that can be removed. Simply confirm me and I will remove. I vote for not removing :)

elemoine · 2015-02-26T12:51:43Z

@acanimal, yes, using the new filter option is trivial, and we can't add an example for every option we add. So I would remove the example.

acanimal · 2015-02-26T19:24:07Z

Sample removed.

elemoine · 2015-02-26T19:26:32Z

Did you see my other comments?

acanimal · 2015-02-26T19:55:56Z

Strange, I didn't receive any notification to my email.
I just make the changes.

acanimal · 2015-03-04T20:28:58Z

@ahocevar @elemoine Hi, what happened with this features? I though it would be merged in the 3.3 release :(
I don't know the the process must follow a PR to be accepted but this feature is important to me at work. Could you let me know some feedback?

Thanks.

ahocevar · 2015-03-04T20:33:24Z

@acanimal Sorry for that. Your pull request cannot be merged without conflicts, this is why it did not get merged yet. Also, it did not have a milestone assigned, so I did not wait for it when I created the release yesterday. But since we have a monthly release schedule, I'm assigning it the 3.4.0 milestone now. So if you are able to resolve the conflicts, we can merge your pull request and it will be in the next release.

acanimal · 2015-03-04T20:36:57Z

I though the conflict was due the addition of #3018, ./build.py ci tasks runs fine and also travis report "green" result.
I will resolve and update the PR.

Thanks

acanimal · 2015-03-12T16:24:13Z

@ahocevar Merge done

ahocevar · 2015-03-12T16:50:19Z

Have you seen @elemoine's last comment?

acanimal · 2015-03-16T19:51:15Z

Sorry for the late reply. Yes, I just uploaded the modified code using this.filter_ property instead a local variable.

tremby · 2015-03-25T20:18:57Z

This feature is important for a project I'm currently working on. Very much looking forward to it being available in 3.4.0. Thanks to those involved.

ahocevar · 2015-03-25T20:21:40Z

@elemoine, are your concerns addressed now?

elemoine · 2015-03-26T06:26:04Z

LGTM. I just think we should squash the commits into one before merging. I will do that myself this morning, and create a new PR.

doronhorwitz · 2015-03-26T08:05:02Z

src/ol/interaction/selectinteraction.js

@@ -27,6 +27,15 @@ ol.SelectEventType = {
 };


+/**
+ * A function that takes an {@link ol.Feature} and an {ol.layer.Layer} and


The link for ol.layer.Layer should be
{@link ol.layer.Layer} - missing the @link

You're right. Thanks for catching this.

acanimal · 2015-05-18T08:58:11Z

Hi,
I'm "disconnected" from the project due time limitation but, why has been removed this PR from 3.5.0? I code it since 3.3 and never released.
Is there any other new functionallity in 3.5 to achieve the same result?

Cheers.

bartvde · 2015-05-18T09:20:24Z

@acanimal it needs a rebase at least, not sure if there are any other reasons.

fredj · 2015-08-31T10:21:54Z

fixed with #3402 ?

elemoine · 2015-09-10T08:05:13Z

fixed with #3402 ?

Yes.

acanimal added 2 commits February 23, 2015 21:50

Added filter function to the select interactions. Added example

15b4129

Added filter function both on select and coditional actions

9ba5a33

acanimal mentioned this pull request Feb 25, 2015

Possibility to restrict the type of features you can select #3257

Closed

Solved check issues

c7c32bb

elemoine reviewed Feb 25, 2015
View reviewed changes

acanimal added 2 commits February 25, 2015 23:02

Solved issues, added documentation. Added a second layer parameter to…

dc7e5ab

… the SelectFilterFunction

Solved issues, added documentation. Added a second layer parameter to…

9861da5

… the SelectFilterFunction

elemoine reviewed Feb 25, 2015
View reviewed changes

Fixed issues

ca326dd

Removed sample for 'filter' property in ol.interaction.Select

d5746a8

Fixed issues

9507530

bjornharrtell mentioned this pull request Mar 2, 2015

Add SelectEvent to interaction #3018

Merged

acanimal mentioned this pull request Mar 4, 2015

Possibility to restrict the type of features you can select #3258

Closed

ahocevar added this to the v3.4.0 milestone Mar 4, 2015

Solved selectinteraction conflicts

2a52e89

acanimal added 5 commits March 12, 2015 10:19

Adding select filtering

49e2dbe

Merge branch 'master' into 3257

9ff99dd

Fixed jshint style issues

46fa677

Fixed merge issues

e18e19c

Fixed merge issues

3f7cea9

Using this.filter_ instead of local variable

f1b7942

doronhorwitz reviewed Mar 26, 2015
View reviewed changes

elemoine mentioned this pull request Mar 26, 2015

Add "filter" option to Select interaction #3402

Merged

bartvde modified the milestones: v3.5.0, v3.4.0 Mar 29, 2015

tschaub removed this from the v3.5.0 milestone May 5, 2015

elemoine closed this Sep 10, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Possibility to restrict the type of features you can select #3277

Possibility to restrict the type of features you can select #3277

acanimal commented Feb 25, 2015

elemoine Feb 25, 2015

elemoine Feb 25, 2015

acanimal Feb 25, 2015

elemoine Feb 25, 2015

acanimal Feb 26, 2015

acanimal commented Feb 25, 2015

elemoine Feb 25, 2015

acanimal Feb 25, 2015

elemoine commented Feb 25, 2015

elemoine Feb 25, 2015

acanimal Feb 25, 2015

acanimal commented Feb 25, 2015

elemoine commented Feb 26, 2015

acanimal commented Feb 26, 2015

elemoine commented Feb 26, 2015

acanimal commented Feb 26, 2015

acanimal commented Mar 4, 2015

ahocevar commented Mar 4, 2015

acanimal commented Mar 4, 2015

acanimal commented Mar 12, 2015

ahocevar commented Mar 12, 2015

acanimal commented Mar 16, 2015

tremby commented Mar 25, 2015

ahocevar commented Mar 25, 2015

elemoine commented Mar 26, 2015

doronhorwitz Mar 26, 2015

elemoine Mar 26, 2015

acanimal commented May 18, 2015

bartvde commented May 18, 2015

fredj commented Aug 31, 2015

elemoine commented Sep 10, 2015

Possibility to restrict the type of features you can select #3277

Possibility to restrict the type of features you can select #3277

Conversation

acanimal commented Feb 25, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acanimal commented Feb 25, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elemoine commented Feb 25, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acanimal commented Feb 25, 2015

elemoine commented Feb 26, 2015

acanimal commented Feb 26, 2015

elemoine commented Feb 26, 2015

acanimal commented Feb 26, 2015

acanimal commented Mar 4, 2015

ahocevar commented Mar 4, 2015

acanimal commented Mar 4, 2015

acanimal commented Mar 12, 2015

ahocevar commented Mar 12, 2015

acanimal commented Mar 16, 2015

tremby commented Mar 25, 2015

ahocevar commented Mar 25, 2015

elemoine commented Mar 26, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acanimal commented May 18, 2015

bartvde commented May 18, 2015

fredj commented Aug 31, 2015

elemoine commented Sep 10, 2015