Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build process should check build requirements #335

Closed
wants to merge 1 commit into from
Closed

Build process should check build requirements #335

wants to merge 1 commit into from

Conversation

marcjansen
Copy link
Member

ol3 has a lot of build requirements. When these are not present, the build fails in strange ways.

The build process should give meaningful messages when these requirements are not met. This includes, for each requirement:

  • checking that the requirement is present
  • checking that the requirement is a supported version

Refs #318.

@marcjansen
Copy link
Member

Commit 858574b adds very basic checking of dependencies without version checking. This might help getting a first idea why the build fails by reporting early that some requirements aren't there.

@marcjansen
Copy link
Member

Now that #358 is merged, is this still relevant? Has anybody a better approach?

@elemoine
Copy link
Member

I'm failing to understand the link to #358 (Mocha). Also, I think we just need to verify that the deps required for the check target are installed. This excludes jsdoc3.

@marcjansen
Copy link
Member

@elemoine. yes #358 is totally unrelated, sorry for the noise.

@twpayne
Copy link
Contributor Author

twpayne commented Apr 5, 2013

Fixed in #448.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants