Fix memory leak when removing layers from ol.layer.Group #3528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| layer, [ol.ObjectEventType.PROPERTYCHANGE, goog.events.EventType.CHANGE], | ||
| this.handleLayerChange_, false, this); | ||
| var key = goog.getUid(layer).toString(); | ||
| goog.asserts.assert(!goog.isDef(this.listenerKeys_[key]), |
There was a problem hiding this comment.
Using goog.asserts.assert(!(key in this.listenerKeys_)) would make more sense to me.
|
I've added a few minor comments. I'd also recommend adding unit-tests to check that that logic is correct and avoid regressions in the future. |
|
@elemoine you're right; units tests must be added. |
|
More unit tests added |
|
+1 |
fredj
added a commit
that referenced
this pull request
Apr 20, 2015
Fix memory leak when removing layers from ol.layer.Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3479