Remove type casts in example sources for display

[marcjansen]

This PR suggests that we remove inline type casts when we display our examples.

Before:

After:

[marcjansen]

I'm not sure if this really does the trick for all cases...

[ahocevar]

Should be defined outside the function to avoid RegEx parsing with every function call.

[ahocevar]

Looks good - maybe you'll want to address my two minor comments before merging. Even if the regex does not catch all cases, it is a good starting point for later improvements.

[marcjansen]

Thanks @ahocevar. I want to test the results first again... It may be that the regex chnges code i don't want it to change.

[marcjansen]

The regex fails to clean up e.g.

view.fitExtent(
      vectorSource.getExtent(), /** @type {ol.Size} */ (map.getSize()));

and turns it into

view.fitExtent(
      vectorSource.getExtent(), );

(examples_src/drag-and-drop-image-vector.js)

Other files with problematic constructs are animation.js or measure.js:

var geom = /** @type {ol.geom.Polygon} */(polygon.clone().transform(
        sourceProj, 'EPSG:4326'));

It may be that the regular expression can be enhanced, but I fear this is going to be hard.

A) I could limit the regex to the attribution options (olx.control.AttributionOptions), which would remove most of the typecasts
B) or the regexp could be changed so it only removes the typecast comment and leaves additional (useless) round parenthesises:

var geom = /** @type {ol.geom.Polygon} */(polygon.clone().transform(
        sourceProj, 'EPSG:4326'));

var geom = (polygon.clone().transform(
        sourceProj, 'EPSG:4326'));

C) or I close this PR as fruitless.

Opinions?

[marcjansen]

B) would most probably be the easiest way.

[ahocevar]

I think both B and C would be fine.

[marcjansen]

Hah, I think I have an easy solution that'll do all I originally intended... I'll see if I can rework this tomorrow.

[marcjansen]

I went for option B as suggested. I think this still is a nice little enhancement and one thing less that may confuse first-time readers. The surrounding round braces stay now, but they do not harm. All problematic cases of the original commit are no longer an issue.

@ahocevar your other remarks are adressed, thanks for your review.

Hah, I think I have an easy solution that'll do all I originally intended... I'll see if I can rework this tomorrow.

I am no longer sure if I can come up with something that also does remove the ( and ).

Anybody willing to give this another look? TIA.

[ahocevar]

The group is not really needed here.

[elemoine]

I might have concerns with this patch, so I'd like to review it before it is merged. Thanks.

[elemoine]

I had misunderstood this patch. I thought it changed the examples' code, while it changed the code that is displayed in the example's page!

That being said, option B (remove typecast but leave brackets) sounds like a half-baked solution to me. So I'd either address the issue completely or go with option C (close this PR as fruitless).

[marcjansen]

No problem. I'll close it then. Any ideas howwe could accomplish this?