-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] New type inference #4793
[WIP] New type inference #4793
Conversation
@fredj, if you want to have a look... |
46879e1
to
6975501
Compare
@@ -47,7 +47,7 @@ ol.events.Event.prototype.stopPropagation = function() { | |||
/** | |||
* @param {Event|ol.events.Event} evt Event | |||
*/ | |||
ol.events.Event.stopPropagation = function(evt) { | |||
ol.events.Event.prototype.stopPropagation = function(evt) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a mistake to me. There are still a number of places in the library that use the ol.events.Event.stopPropagation
function. With this change, that will be undefined
. I hope this causes at least a few test failures.
Not sure why you'd want it to be a prototype member. A name like ol.events.stopPropagation
could make sense, but it doesn't need to be accessible from ol.events.Event
instances.
Move olx.interaction before assignation. Explicitly create objects.
Due to `ol.format.GML = ol.format.GML3;`, these are duplicates.
They actually resolve to `Function`. See google/closure-compiler#202
Avoid circular typedef.
Breaks circular dependency.
Added to ol.Disposable and ol.events.EventTarget.
Avoid closure complaining about stopPropagation method not being present in base class.
94e26a8
to
35351aa
Compare
The |
@gberaudo I notice a couple of typedef-related changes in here. First, LRUCache looks like it should be changed to an interface, so I won't include this in my typedef PR. Second, in |
@probins, thank you for caring about this PR. |
Switch to the new type inference version of the compiler.
See https://github.com/google/closure-compiler/wiki/Using-NTI-%28new-type-inference%29
There are only 2 errors left:
TODO:
structs can only extend structs
error;