Ensure polygons without stroke are fully filled #6358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahocevar
force-pushed
the
canvas-moveto
branch
2 times, most recently
from
9735712
to
fca88a4
Compare
ahocevar
force-pushed
the
canvas-moveto
branch
from
fca88a4
to
3b48c1c
Compare
ahocevar
force-pushed
the
canvas-moveto
branch
from
3b48c1c
to
a671687
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because polygons without stroke are only implicitly closed (i.e. without
closePath()calls), optimizing awaymoveTo()calls when the previouslineTo()coordinate matches themoveTo()coordinate results in polygons whose last vertex is not included in the filled area.Resetting the previous coordinate causes
moveTo()to be called after a fill, which fixes the issue.Fixes #6341.