Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature apidoc, fix events and observable properties #6370

Merged
merged 1 commit into from Jan 23, 2017

Conversation

tchandelle
Copy link
Contributor

id and style are not observable, and so, don't trigger change:id and change:style events, but just a change event

@ahocevar
Copy link
Member

Interesting. It looks like geometry is also not observable.

@tchandelle
Copy link
Contributor Author

tchandelle commented Jan 16, 2017

geometry is observable, but only when geometryName is 'geometry'. This may need some clarification.

@ahocevar
Copy link
Member

ahocevar commented Jan 16, 2017

Ah, I see now that setGeometryName() updates the object listener for the geometry name. So the geometry is observable, regardless of the geometryName.

Copy link
Member

@fredj fredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fredj fredj merged commit a7d30e6 into openlayers:master Jan 23, 2017
@tchandelle tchandelle deleted the feature-events branch January 23, 2017 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants