Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gml2 serializers to support WFS-T 1.0.0 #6523

Merged
merged 8 commits into from Mar 20, 2017
Merged

Add Gml2 serializers to support WFS-T 1.0.0 #6523

merged 8 commits into from Mar 20, 2017

Conversation

Jenselme
Copy link
Contributor

This PR adds writeFeatureElement and related serializers to ol.format.GML2. This will allow support for WFS-T version 1.0.0 (currently only 1.1.0 is supported witch GML3) I tested the serializers against a WFS 1.0.0 server (GeoServer) for these geometries:

  • Lines
  • Polygons
  • Points
  • MultiLines
  • MultiPoints
  • MultiPolygons

For these tests, in addition to these patches, I also applied a patch to use ol.format.GML2.prototype.writeFeatureElement in ol.format.WFS.prototype.writeTransaction. For those interested, the patch is here. I intend to open a PR for this as soon as this one is merged.

Julien Enselme added 8 commits February 17, 2017 15:38
Boostrap GML2 serializers
7f0ed44 
- Add writeFeatureElement (copied and adapted from ol.format.GML3)
- Add writeGeometryElement (copied and adapted from ol.format.GML3)
- Add related constants (GEOMETRY_SERIALIZERS_, GEOMETRY_NODE_FACTORY_)
- Add empty serialization methods
Add GML2 serializer for Curve and LineString
2139482 
Adapt the code from ol.format.GML3.
Add GML2 serializer for Surface and Polygon
dd90c90 
- Adapt the code from ol.format.GML3.
- Create utility function to create coordinates nodes with proper
attributes
Add GML2 serializer for Point
f8c6863
Add GML2 serializer for MultiPoint
650837b
Add GML2 MultiLineString serialiazer
579ec39
Add GML2 serializer for MultiSurface and MultiPolygon
fec279c
Add GML2 serializer for Envelope
5f5c906
ahocevar added a commit to openlayers/cla that referenced this pull request Feb 23, 2017
@ahocevar
Add CCLA for Ioda-Net Sàrl
92c510b 
Thanks @Jenselme for openlayers/openlayers#6523 and openlayers/openlayers#6524.
@Jenselme
Copy link
Contributor Author

Any interest in this?

@bartvde
Copy link
Member

bartvde commented Mar 14, 2017

Can you explain the rationale? Are there WFS-s out there that don't support WFS 1.1?

@Jenselme
Copy link
Contributor Author

Are there WFS-s out there that don't support WFS 1.1?

Sadly yes.

  • TinyOWS : only supports getting the features and creating new ones in WFS-1.1.0. Creation and update are currently 1.0.0 only.
  • QGIS Server : only supports update in WFS-T 1.1.0. See this issue where a user asks for WFS-T 1.1.0 and 2.0.0

Since we don't want to use GeoServer in our infrastructure (huge Java service), we have to rely on TinyOWS or QGIS to support WFS-T in our solutions. Hence this feature proposal to add GML2 serializers and then use them to get full WFS-T 1.0.0 support in OpenLayers.

@bartvde
Copy link
Member

bartvde commented Mar 17, 2017

ok thanks for explaining, then it makes sense IMHO. Your code looks good at first glance, I hope to find some time for a proper review soon. Thanks for your patience.

@Jenselme
Copy link
Contributor Author

I hope to find some time for a proper review soon

Looking forward to that.

Thanks for your patience.

No problem.

@bartvde
Copy link
Member

bartvde commented Mar 20, 2017

thank you for this solid contribution @Jenselme

@bartvde bartvde merged commit d931a92 into openlayers:master Mar 20, 2017
@Jenselme Jenselme mentioned this pull request Mar 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jenselme @bartvde