Trigger when nothing has been (de)selected #6541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past ol.interaction.Select used to fire a 'select' event even when there were no features selected/deselected. A condition was added to prevent this event from firing when there was nothing selected/deselected. I'm proposing a new event, "empty", which fires when nothing was selected/deselected. Without this I believe an explicit map.on("click") handler is required and managing the interaction with the map click and the select interaction gets messy.
|
I can see the use case, but I think I'd prefer just triggering the existing |
ca0v
added a commit
to ca0v/ol3
that referenced
this pull request
Mar 1, 2017
|
@bjornharrtell I'm failing to commit with test and can't figure out how to build test_requires.js (I'm on windows, no make). |
|
Sorry, can't put time into this if you want it done in the short term (days). I suggest getting a prompt with make, or even better use a *nix. :) |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past ol.interaction.Select used to fire a 'select' event even when there were no features selected/deselected. A condition was added to prevent this event from firing when there was nothing selected/deselected. I'm proposing a new event, "empty", which fires when nothing was selected/deselected. Without this I believe an explicit map.on("click") handler is required and managing the interaction with the map click and the select interaction gets messy.