Make strokeKey safer #7513
Merged
Make strokeKey safer #7513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredj
approved these changes
Nov 27, 2017
mdastous-bentley
pushed a commit
to BentleySystems/openlayers
that referenced
this pull request
May 27, 2020
Make strokeKey safer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite minor, but the
strokeKeyfor the label cache currently ends with the scale, which is an arbitrary number. Since the text itself is appended to thestrokeKeyfor thecacheKey, it is possible that they interfer.By changing the order so the
strokeKeyends with thetextAlign, which is a known value, we can avoid that potential glitch.Note: we do not use a delimiter because generating these cache keys is on the hot path, and string concatenation gets drastically slower with an increased number of chunks.