Added updateSketchCondition as a Draw Interaction option #7535
Conversation
bjornharrtell
commented
Dec 4, 2017
•
bjornharrtell
commented
- This pull request addresses an issue that has been marked with the 'Pull request accepted' label & I have added the link to that issue.
- It contains one or more small, incremental, logically separate commits, with no merge commits.
- I have used clear commit messages.
- Existing tests pass for me locally & I have added or updated tests for new or changed functionality.
- The work herein is covered by a valid Contributor License Agreement (CLA).
|
Replaces #4668. Trivial addition but should be unit tested, I realize now due to the nice reminders in the new PR template. |
| * @type {ol.EventsConditionType|undefined} | ||
| * @api | ||
| */ | ||
| olx.interaction.DrawOptions.prototype.updateSketchCondition; |
There was a problem hiding this comment.
The new option must also be added in the olx.interaction.DrawOptions @typedef above.
There was a problem hiding this comment.
Thanks for noticing, fixed by b53d61d.
|
This PR is a suggested fix for the issue #3907 which was created before the "Pull request accepted" label was introduced. |
|
I'm not sure CLA was established for @Daanoz. However, the changes are quite trivial. |
|
Hi, thx for the interest in closing this PR. Since I've submitted this PR (and it's fix) as part of an enterprise application, I also rather get the CLA signed by the enterprise rather than me personally signing it. But, that has proven to be quite the challenge, the related ticket has been on our own scrumboard for over an year now, so I can imagine the pain with having this ticket open for so long. Therefore I propose to just close this ticket and the branch, and see if someone else is willing to pick it up in the future, otherwise we're stuck in this deadlock? |
|
I would like to pick it up and start from scratch, but it will likely result in mostly identical implementation - not sure if that's ok or not. Also, I've tried to make unit tests but got stuck on the event simulation, so I'll need some more time on it. Not expecting to get get it done until after 4.6 and so will close this. |
