-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parser for OGC Filter version 1.0 and 1.1 #773
Conversation
Adds a parser for OGC Filter Encoding version 1.0.0 and 1.1.0. The parser supports read and write.
Thanks @bartvde. As a polite request, is it possible to split large changes like this into multiple commits? This would make it much easier to review. |
@twpayne there isn't actually so much code here, it's only 3 classes and they are inter-related. Most of it is XML files for the tests. |
Maybe I misinterpreted on the need for squashing, maybe @elemoine only meant following the commit message standard would have been nice, not the squashing part of my previous comment: |
I find that the commit history is a useful narrative for understanding the approach. For example, in this case, it could be something like:
This, to me, is much more descriptive and indicates that the commit includes other changes. |
but still all this narrative could be put into the commit message (I should have done a better job at the commit message in this case, but I did not put too much effort in it since likely a bigger part of this is still gonna change). |
True, but when looking at the commit history you don't always see the full commit message, and single large commits that affect many different parts of the codebase don't play well with |
Fortunately, it's a language we all should be familiar with :) We can work on this in either direction. I'm close to having a pull request ready for expression parsing. It will replace our current Anyway, I'll try to wrap up a pull request today. Then we can talk about where to do the integration work. |
@tschaub let me know when your PR request is ready, and I'll adapt my code gladly to use the new structures. |
Indeed :) |
Closing this one, will open up a new one once I finish the integration |
Adds a parser for OGC Filter Encoding version 1.0.0 and 1.1.0. The parser
supports read and write.
This is not yet ready for review since it depends on the javascript filter language that @tschaub is working on, this will need to be integrated later, but I thought I'd put this out here already.