Multiline strings are not rendered correctly due to typo in VectorLayer #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously read 'multilinstring' instead of 'multilinestring'. Letting the compiler check for typos instead now.
|
Nice catch @jystic. I modified this to use the |
|
Interested in an easy review @ahocevar? |
|
Looks solid. Please merge. |
tschaub
added a commit
that referenced
this pull request
Jun 25, 2013
Multiline strings are not rendered correctly due to typo in VectorLayer
afabiani
pushed a commit
to geosolutions-it/openlayers
that referenced
this pull request
May 22, 2017
Pinch preserve center
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a typo in the parser lookup dictionary for feature types:
https://github.com/openlayers/ol3/blob/master/src/ol/layer/vectorlayer.js#L343
The line says:
but it should say:
Multilinestrings are still parsed but they do not use the shared vertex storage area and so when transforming to a different projection these features are skipped.