Parse MultiGeometry in KML #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MultiLineString case was correct here. The MultiPoint and MultiPolygon cases should be using the constructor instead of the `fromParts` factories.
As demonstrated in the tests, a MultiGeometry may contain other MultiGeometry nodes. We can support this with heterogenous GeometryCollection instances - though these are not currently rendered.
|
thanks for this @tschaub LGTM please merge |
afabiani
pushed a commit
to geosolutions-it/openlayers
that referenced
this pull request
May 22, 2017
Default fallThrough to false
afabiani
pushed a commit
to geosolutions-it/openlayers
that referenced
this pull request
May 22, 2017
afabiani
pushed a commit
to geosolutions-it/openlayers
that referenced
this pull request
May 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
kml:MultiGeometryparsing forol.geom.MultiPoint,ol.geom.MultiPolygon, andol.geom.GeometryCollection. As mentioned in the commits,kml:MultiGeometrymay be nested. We don't currently render heterogeneous collections, but this at least gets us parsing them.