Don't react to keyboard events when the focus is on editable inputs #903
Conversation
| @@ -240,7 +240,6 @@ ol.Map = function(options) { | |||
| this.handleMapBrowserEvent, false, this); | |||
| this.registerDisposable(mapBrowserEventHandler); | |||
|
|
|||
| // FIXME we probably shouldn't listen on document... | |||
There was a problem hiding this comment.
I'm not sure that this comment should be removed :)
What should be the behaviour when there are two maps on the page and the user presses an arrow key? Should both maps scroll or just one?
There was a problem hiding this comment.
(comment re-added)
I had removed the comment because we have to listen on document.
There was a problem hiding this comment.
Is it possible to listen just on the map div? IIRC you need to add the tabindex="0" attribute to the div. There's some discussion on Stack Overflow here and here.
I don't know much about keyboard event handling, so it's entirely possible that I've missed something important here. Don't hesitate to tell me what it is :)
There was a problem hiding this comment.
Without any focus (click or tab), the event target is always document.body.
The tabindex="0" trick allows the div to be focusable and to be able to receive keyboard events; the div still need to be focused (click or tab).
There was a problem hiding this comment.
this means that we can't just listen on the map div because the user will still have to manually focus the div.
There was a problem hiding this comment.
Thanks for the explanations @fredj. That makes perfect sense.
There was a problem hiding this comment.
It would be good to also support the mode where keyboard interaction is active only when the map div has the focus. That's why ol2's keyboard handler has the observedElementoption: https://github.com/openlayers/openlayers/blob/master/lib/OpenLayers/Handler/Keyboard.js#L41.
There was a problem hiding this comment.
Do you think that the default behavior should be same as ol2 (only react when the map div has the focus) ?
EDIT: in ol2, the default is to listen to document
There was a problem hiding this comment.
I think that, eventually, it will make sense to that an option for that (as in ol2).
|
Looks good - it's an improvement and I'm +1 for merging - but I think that we still don't handle keyboard events correctly. |
|
What's implemented in ol2 is also relevant I think. |
The implementation is more or less the same: In ol2, it's the control responsibility to test if the focus is on an input (see |
|
Looks good to me. Please merge. |
Don't react to keyboard events when the focus is on editable inputs
Google Maps and WMS layer Backbuffer error. r=@mosesonline
Don't pan or zoom when the focus is on an editable inputs (
input,selectortextarea)