Reworked the Webgl Heatmap layer & associated utilities #9041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some expected attributes might not end up in the compiled shader. In this case, skip calling enableVertexAttrib
Now opacity, rotateWithView and tex coords can be set with callbacks per feature.
Now the layer opacity is simply handled by a CSS property on the layer DOM element. As such it does not have to be taken into account in shaders.
Things done: - stay closer to the original rendering in canvas - get rid of the intermediary blur step - use the new callbacks in the webgl points renderer - premultiply alpha in the last postprocessing step
jahow
force-pushed
the
fix-webgl-ff-bug
branch
from
bf6dc00
to
ecd42ac
Compare
jahow
force-pushed
the
fix-webgl-ff-bug
branch
from
ecd42ac
to
8e4c66a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #9014 for good & generally improve the webgl-related classes.
Now the Heatmap layer should be much more resemblant to the original implementation, but with better performance overall.
Also the API of the Webgl Points renderer is now more powerful, with callbacks for opacity, rotation lock and texture coords (more examples to come).
The glitches have been removed by properly handling premultiplied alpha, which wasn't the case before. As layers are individual DOM elements, handling transparency on each of them is mandatory but this can be tricky with WebGL. Now things should be working consistently in any browser inc. in the CI.
This PR:
5.3.0:
