Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the header and bad data in CSV parsing #9440

Merged
merged 1 commit into from Apr 18, 2019
Merged

Skip the header and bad data in CSV parsing #9440

merged 1 commit into from Apr 18, 2019

Conversation

tschaub
Copy link
Member

@tschaub tschaub commented Apr 17, 2019

In the CSV parsing examples, the prevIndex === 0 condition is never met, so the first coords created have NaN values. The filter-points-webgl example still works because the renderer gets all features in the "infinite" extent. When this same parsing logic is used with a regular vector layer, no features are rendered because of the one(s) with NaN coordinates (one for the header line and one later in the file with no lon/lat).

Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@tschaub tschaub merged commit a71a823 into openlayers:master Apr 18, 2019
@tschaub tschaub deleted the csv-parsing branch April 18, 2019 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants