Skip the header and bad data in CSV parsing #9440
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the CSV parsing examples, the
prevIndex === 0
condition is never met, so the first coords created haveNaN
values. Thefilter-points-webgl
example still works because the renderer gets all features in the "infinite" extent. When this same parsing logic is used with a regular vector layer, no features are rendered because of the one(s) withNaN
coordinates (one for the header line and one later in the file with no lon/lat).