Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Zoomify to display retina tiles #9489

Merged
merged 1 commit into from May 14, 2019
Merged

Conversation

crubier
Copy link
Contributor

@crubier crubier commented May 3, 2019

This is a small PR that changes a few lines in zoomify source:

@crubier
Copy link
Contributor Author

crubier commented May 5, 2019

Before:

Screenshot 2019-05-03 at 23 51 30

After:

Screenshot 2019-05-03 at 23 51 37

@crubier
Copy link
Contributor Author

crubier commented May 6, 2019

This is a small PR, how long can we expect before review, merge and release ? Thank you :-) 🙏

@crubier
Copy link
Contributor Author

crubier commented May 8, 2019

@tschaub or @ahocevar , let me know if there is anything I can do to help you expedite this :-)

@tschaub
Copy link
Member

tschaub commented May 8, 2019

@crubier - minor point, but it would be nice to squash all those commits into fewer that represent sensible chunks of work. It looks like this work could be a single commit.

As a general practice, if you git pull --rebase openlayers master you can have your work rebased on the latest from the hosted master branch without introducing merge commits. There are some good docs online about squashing commits if you haven't done that before.

@crubier
Copy link
Contributor Author

crubier commented May 8, 2019

@tschaub Ok thank you, done

@crubier
Copy link
Contributor Author

crubier commented May 13, 2019

@tschaub up :-)

@tschaub tschaub merged commit 8504a49 into openlayers:master May 14, 2019
@crubier
Copy link
Contributor Author

crubier commented May 15, 2019

👍

@jameshoward
Copy link

Just in case anyone runs into the same issue as me, the only reason the example works when setting tileSize to 256 / pixelRatio is because the example image server effectively ignores the tile group directory. For example, http://vips.vtech.fr/cgi-bin/iipsrv.fcgi?zoomify=/mnt/MD1/AD00/plan_CHU-4HD-01/FOND.TIF/TileGroup1/2-0-0.jpg and http://vips.vtech.fr/cgi-bin/iipsrv.fcgi?zoomify=/mnt/MD1/AD00/plan_CHU-4HD-01/FOND.TIF/TileGroup100/2-0-0.jpg return the same image.

If you try to use the same method using an image from another Zoomify source (e.g. the converter), you will likely get 404 errors when trying to load tiles because the tile grouping calculations are different between the generated image and the ZoomifySource.

@crubier
Copy link
Contributor Author

crubier commented Jan 3, 2020

@jameshoward did you find a solution to this? I was not aware of this problem, only tried on the demo (The server of the demo image is down now actually...)

@ahocevar
Copy link
Member

The remaining issue was fixed with #10562.

@jameshoward
Copy link

@crubier No, I didn't find a solution other than to tweak the generator that was creating my tiles to output them at 256x256. The solution is #10562 looks great though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HiDPI / retina / pixelRatio zoom levels for tiled image sources (Zoomify, etc.)
4 participants