Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary parts from the Mapbox layer example #9534

Merged
merged 1 commit into from May 15, 2019
Merged

Remove unnecessary parts from the Mapbox layer example #9534

merged 1 commit into from May 15, 2019

Conversation

tschaub
Copy link
Member

@tschaub tschaub commented May 14, 2019

As far as I could tell, these view settings are not required by the Mapbox layer example:

  • minZoom: 1
  • extent: [-Infinity, -20048966.10, Infinity, 20048966.10]
  • smoothExtentConstraint: false
  • smoothResolutionConstraint: false

In addition, since the render function has access to frameState.viewState, I removed the map.getView() call. Since this will only work with a EPSG:3857 view, I removed the view.getProjection() call. And since the focus of this example is the Mapbox layer, I moved the vector layer to the bottom of the example.

@tschaub
Copy link
Member Author

tschaub commented May 15, 2019

If #9545 is merged first, I'll remove the extent: [-Infinity, -20048966.10, Infinity, 20048966.10] from the view. If this gets in first, I'll update the other branch to remove the extent (I confirmed that the example works without the extent after the changes in #9545).

@tschaub tschaub merged commit 5a4541d into openlayers:master May 15, 2019
@tschaub tschaub deleted the simpler-mapbox-layer-example branch May 15, 2019 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants