Remove handleMapPostrender extension point #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -99,8 +99,7 @@ ol.control.Control.prototype.setMap = function(map) { | |||
| var target = goog.isDef(this.target_) ? | |||
| this.target_ : map.getOverlayContainer(); | |||
| goog.dom.appendChild(target, this.element); | |||
| if (this.handleMapPostrender !== | |||
| ol.control.Control.prototype.handleMapPostrender) { | |||
| if (this.handleMapPostrender !== goog.nullFunction) { | |||
There was a problem hiding this comment.
Nice. Much more understandable this way.
There was a problem hiding this comment.
goog.nullFunction was used before, but I could not use goog.nullFunction and have the handleMapPostrender function show up in the API doc. See https://github.com/elemoine/ol3/commit/3a4fc2a99a5eda0df297dec4f8b5939b8aab09e6.
|
Please merge. |
elemoine
pushed a commit
that referenced
this pull request
Sep 1, 2013
Remove handleMapPostrender extension point
afabiani
pushed a commit
to geosolutions-it/openlayers
that referenced
this pull request
Nov 7, 2017
TextButtonPanel, Attempt 2 (Zoom-Control-like text+CSS buttons)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the handleMapPostrender extension point for custom controls. See this comment for the motivations of this removal.