Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev version based on time #9969

Merged
merged 1 commit into from Sep 23, 2019
Merged

Dev version based on time #9969

merged 1 commit into from Sep 23, 2019

Conversation

tschaub
Copy link
Member

@tschaub tschaub commented Sep 23, 2019

Currently, we pick increment the prerelease id based on the latest dev release published to npm. This means that if we merge two pull requests in close succession, the second will fail if it checked the latest version before the first was complete.

This branch changes things so we still have a race, but it only occurs if two jobs start in the same millisecond.

Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

Copy link
Member

@marcjansen marcjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💨 ✔️

@tschaub tschaub merged commit cf5b568 into openlayers:master Sep 23, 2019
@tschaub tschaub deleted the next-dev-version branch September 24, 2019 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants