Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid error from tsc #9997

Merged
merged 1 commit into from Sep 25, 2019
Merged

Avoid error from tsc #9997

merged 1 commit into from Sep 25, 2019

Conversation

tschaub
Copy link
Member

@tschaub tschaub commented Sep 25, 2019

Without this change, we get obscure failures from tsc like this:

/home/runner/work/openlayers/openlayers/node_modules/typescript/lib/tsc.js:72973
                throw e;
                ^

TypeError: Cannot read property 'flags' of undefined
    at createSymbolWithType (/home/runner/work/openlayers/openlayers/node_modules/typescript/lib/tsc.js:36787:46)
    at getUnionSignatures (/home/runner/work/openlayers/openlayers/node_modules/typescript/lib/tsc.js:30929:53)
    at resolveUnionTypeMembers (/home/runner/work/openlayers/openlayers/node_modules/typescript/lib/tsc.js:31021:34)
    at resolveStructuredTypeMembers (/home/runner/work/openlayers/openlayers/node_modules/typescript/lib/tsc.js:31330:21)
    at getSignaturesOfStructuredType (/home/runner/work/openlayers/openlayers/node_modules/typescript/lib/tsc.js:31782:32)
    at getSignaturesOfType (/home/runner/work/openlayers/openlayers/node_modules/typescript/lib/tsc.js:31788:20)
    at resolveCallExpression (/home/runner/work/openlayers/openlayers/node_modules/typescript/lib/tsc.js:42223:34)
    at resolveSignature (/home/runner/work/openlayers/openlayers/node_modules/typescript/lib/tsc.js:42494:28)
    at getResolvedSignature (/home/runner/work/openlayers/openlayers/node_modules/typescript/lib/tsc.js:42514:26)
    at checkCallExpression (/home/runner/work/openlayers/openlayers/node_modules/typescript/lib/tsc.js:42585:29)

We should try to narrow this down and file an upstream issue. But this temporarily gets things working again.

See https://github.com/openlayers/openlayers/runs/235397246 for an example failure.

Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tschaub tschaub merged commit ff4006f into openlayers:master Sep 25, 2019
@tschaub tschaub deleted the tsc-fix branch September 25, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants