Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades to CdiPanel configuration #161

Closed

Conversation

petecressman
Copy link
Contributor

Implement closing dialog to let user go back and write changes. Remind
user to save panel when sensor or turnout is made. Enable/disable 'Write
All' button (formerly Save changes button) according to whether saves
are needed. Suppress 'end update' message when no changes have been
made. Fix create sensor/turnout titled panel. Set Collapse panels title
to bold. Set default directory for backup and restore to user's choice
of file location in preferences.

user to save panel when sensor or turnout is made. Enable/disable 'Write
All' button (formerly Save changes button) according to whether saves
are needed. Suppress 'end update' message when no changes have been
made. Fix create sensor/turnout titled panel. Set Collapse panels title
to bold.  Set default directory for backup and restore to user's choice
of file location in preferences.
@atanisoft
Copy link

There appears to be some whitespace consistency issues in the updated CdiPanel.java file. It would be good to clean this up prior to merge.

@pabender
Copy link
Member

Closing and opening to see if the CI build runs.

@pabender pabender closed this Mar 26, 2020
@pabender pabender reopened this Mar 26, 2020
@pabender
Copy link
Member

There appears to be an issue with the configuration on Travis that crept up since the last PR on the repo. Let me fix that so CI completes before we put this in.

@petecressman
Copy link
Contributor Author

The problem might be with a mal-formed panel file that I have used as a negative test for some of my error checking in Circuit Builder. (SignalMast with a bad system name). If this is the problem, I can delete the offending mast in the file.

@petecressman
Copy link
Contributor Author

It's Apveyor with that problem. I think CI needs me to do something about maven. I will get to that soon.

@pabender
Copy link
Member

@petecressman i checked the logs on Travis. There is a configuration error there before it even gets to the maven build.

In other words, it isn’t even getting to maven to build your code.

Copy link
Contributor

@rhwood rhwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petecressman You've replaced all indenting spaces with tabs. Please undo that, so we can see just your changes, and not that every line in the file has changed.

@petecressman
Copy link
Contributor Author

Withdraw this PR until those who asked me to do this have reviewed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants