Rj cleanup ide warnings and code formatting #163
Conversation
| if (o == null) return false; | ||
| if (o == null) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
This addition is causing a spot bugs error in the build:
[INFO] org.openlcb.swing.NodeSelector$ModelEntry defines equals and uses Object.hashCode() [org.openlcb.swing.NodeSelector$ModelEntry] At NodeSelector.java:[lines 169-178] HE_EQUALS_USE_HASHCODE
335[INFO]
The next line Includes an instanceof operator. Instanceof returns false for null, so the null case is already handled.
There was a problem hiding this comment.
Removed null check in equals() as requested. Also added hashCode() to potentially fix spot bugs warning.
Could you please give me a hint on how to execute spot bugs to prevent such warnings on future changes?
There was a problem hiding this comment.
Spogbugs is run on travis using the following Maven command:
mvn clean verify -U -P spotbugs --batch-mode -Dmaven.javadoc.skip=true
First batch of changes to clean up warnings of eclipse IDE and improve code formatting. Patch does not change internal logic.