Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic from named option::run #40

Closed
coryb opened this issue Mar 22, 2020 · 0 comments · Fixed by #45
Closed

panic from named option::run #40

coryb opened this issue Mar 22, 2020 · 0 comments · Fixed by #45
Labels
bug Something isn't working needs test

Comments

@coryb
Copy link
Contributor

coryb commented Mar 22, 2020

Input:

fs default() {
  image "alpine:latest"
  run "pwd" with myopt
}

option::run myopt() {
  dir "/tmp"
}

Error:

$ ./hlb run ./tests/bug.hlb
panic: unknown with option kind

goroutine 1 [running]:
github.com/openllb/hlb/codegen.(*CodeGen).EmitWithOption(0xc000433f40, 0x1ac19c0, 0xc000452940, 0xc00059b620, 0xc000443810, 0xc000453b40, 0x19c79a8, 0xc00025ea28, 0x101671f, 0xd, ...)
        /go/src/hlb/codegen/codegen.go:429 +0x206
github.com/openllb/hlb/codegen.(*CodeGen).EmitFilesystemChainStmt(0xc000433f40, 0x1ac19c0, 0xc000452940, 0xc00059b620, 0x198a535, 0x2, 0xc000443810, 0x19c79a8, 0xc000595ec0, 0x0, ...)
        /go/src/hlb/codegen/codegen.go:440 +0xa5
github.com/openllb/hlb/codegen.(*CodeGen).EmitChainStmt(0xc000433f40, 0x1ac19c0, 0xc000452940, 0xc00059b620, 0x198a535, 0x2, 0xc000443810, 0x19c79a8, 0x0, 0x19c79a8, ...)
        /go/src/hlb/codegen/codegen.go:196 +0x9c
github.com/openllb/hlb/codegen.(*CodeGen).EmitBlock(0xc000433f40, 0x1ac19c0, 0xc000452940, 0xc00059b620, 0x198a535, 0x2, 0xc000433ff0, 0x2, 0x2, 0x19c79a8, ...)
        /go/src/hlb/codegen/codegen.go:171 +0x611
github.com/openllb/hlb/codegen.(*CodeGen).EmitFilesystemBlock(0xc000433f40, 0x1ac19c0, 0xc000452940, 0xc00059b620, 0xc000433ff0, 0x2, 0x2, 0x19c79a8, 0x0, 0x0, ...)
        /go/src/hlb/codegen/codegen.go:221 +0xd7
github.com/openllb/hlb/codegen.(*CodeGen).EmitFuncDecl(0xc000433f40, 0x1ac19c0, 0xc000452940, 0xc00059b5e0, 0xc00047bf80, 0xc00025f8c8, 0x0, 0x0, 0x19c79a8, 0xc00044ab50, ...)
        /go/src/hlb/codegen/decl.go:45 +0x2ac
github.com/openllb/hlb/codegen.(*CodeGen).EmitFilesystemFuncDecl(0xc000433f40, 0x1ac19c0, 0xc000452940, 0xc00059b5e0, 0xc00047bf80, 0xc00025f8c8, 0x19c79a8, 0x0, 0x0, 0x0, ...)
        /go/src/hlb/codegen/decl.go:56 +0xba
github.com/openllb/hlb/codegen.(*CodeGen).Generate(0xc000433f40, 0x1ac19c0, 0xc000452940, 0xc00025f8c8, 0xc00030ae10, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /go/src/hlb/codegen/codegen.go:71 +0x2dc
github.com/openllb/hlb.Compile.func1(0xc0000a0cc0, 0xc00025f628)
        /go/src/hlb/hlb.go:74 +0x12a
github.com/docker/buildx/util/progress.Write(0x1abb240, 0xc00059b780, 0xc000370f20, 0x19, 0xc00025f830)
        /go/pkg/mod/github.com/docker/buildx@v0.3.1/util/progress/writer.go:32 +0x257
github.com/openllb/hlb.Compile(0x1ac19c0, 0xc000452940, 0xc000010868, 0xc000464360, 0x198d93b, 0x7, 0x1aa9ec0, 0xc000010838, 0x0, 0x0, ...)
        /go/src/hlb/hlb.go:86 +0x637
github.com/openllb/hlb/cmd/hlb/command.Run(0x1ac19c0, 0xc000452940, 0xc000010868, 0x1ab5e40, 0xc000010838, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /go/src/hlb/cmd/hlb/command/run.go:143 +0x2cd
github.com/openllb/hlb/cmd/hlb/command.glob..func5(0xc000452900, 0x0, 0x0)
        /go/src/hlb/cmd/hlb/command/run.go:71 +0x53c
github.com/urfave/cli/v2.(*Command).Run(0x2073fa0, 0xc0004525c0, 0x0, 0x0)
        /go/pkg/mod/github.com/urfave/cli/v2@v2.1.1/command.go:161 +0x4e0
github.com/urfave/cli/v2.(*App).RunContext(0xc000001c80, 0x1ac1a00, 0xc0000380c8, 0xc0000321b0, 0x3, 0x3, 0x0, 0x0)
        /go/pkg/mod/github.com/urfave/cli/v2@v2.1.1/app.go:302 +0x814
github.com/urfave/cli/v2.(*App).Run(...)
        /go/pkg/mod/github.com/urfave/cli/v2@v2.1.1/app.go:211
main.main()
        /go/src/hlb/cmd/hlb/main.go:12 +0x67
@coryb coryb added the bug Something isn't working label Mar 22, 2020
coryb added a commit to coryb/hlb that referenced this issue Mar 23, 2020
hinshun added a commit that referenced this issue Mar 23, 2020
[#40] fix usage of `with myoption`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants