Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer patches incompatible with shardj/zf1-future (1.23.2) #3445

Closed
twosg opened this issue Aug 17, 2023 · 3 comments
Closed

Composer patches incompatible with shardj/zf1-future (1.23.2) #3445

twosg opened this issue Aug 17, 2023 · 3 comments
Labels

Comments

@twosg
Copy link

twosg commented Aug 17, 2023

Preconditions (*)

  1. OpenMage 19.5.0
  2. PHP 8.1

Steps to reproduce (*)

  1. Simply composer update will install shardj/zf1-future in version 1.23.2 which results in two patches not applicable

Expected result (*)

  1. Patches are installed without errors

Actual result (*)

  1. Patches give error

Composer output:

- Installing shardj/zf1-future (1.23.2): Extracting archive
  - Applying patches for shardj/zf1-future
    https://raw.githubusercontent.com/OpenMage/composer-patches/74862e7a9fa29dd62c5c02d585d931ce9e3c5815/patches/MAG-1.1.1.patch (MAG-1.1.1)
    https://raw.githubusercontent.com/OpenMage/composer-patches/74862e7a9fa29dd62c5c02d585d931ce9e3c5815/patches/MAG-1.9.3.0.patch (MAG-1.9.3.0)
    https://raw.githubusercontent.com/OpenMage/composer-patches/74862e7a9fa29dd62c5c02d585d931ce9e3c5815/patches/MAG-1.9.3.7.patch (MAG-1.9.3.7 - SUPEE-10415)
    https://raw.githubusercontent.com/OpenMage/composer-patches/74862e7a9fa29dd62c5c02d585d931ce9e3c5815/patches/MAG-1.9.3.9.patch (MAG-1.9.3.9)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://raw.githubusercontent.com/OpenMage/composer-patches/74862e7a9fa29dd62c5c02d585d931ce9e3c5815/patches/MAG-1.9.3.9.patch
    https://raw.githubusercontent.com/OpenMage/composer-patches/74862e7a9fa29dd62c5c02d585d931ce9e3c5815/patches/OM-918.patch (OM-918 - Add runtime cache to Zend_Locale_Data)
    https://raw.githubusercontent.com/OpenMage/composer-patches/74862e7a9fa29dd62c5c02d585d931ce9e3c5815/patches/OM-1081.patch (OM-1081 - Not detecting HTTPS behind a proxy)
    https://raw.githubusercontent.com/OpenMage/composer-patches/74862e7a9fa29dd62c5c02d585d931ce9e3c5815/patches/OM-2047.patch (OM-2047 - Pass delimiter char to preg_quote)
    https://raw.githubusercontent.com/OpenMage/composer-patches/74862e7a9fa29dd62c5c02d585d931ce9e3c5815/patches/OM-2050.patch (OM-2050 - Prevent checking known date codes)
    https://raw.githubusercontent.com/OpenMage/composer-patches/52f16eda0dc78ba95945ccab8e47f4c642584333/patches/OM-ZF1F-344.patch (OM-ZF1F-344 - Emails are displayed incorrectly in PHP 8.1+)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://raw.githubusercontent.com/OpenMage/composer-patches/52f16eda0dc78ba95945ccab8e47f4c642584333/patches/OM-ZF1F-344.patch

Probably the patches do not apply for this version?

@twosg twosg added the bug label Aug 17, 2023
@fballiano
Copy link
Contributor

I think at the moment you can't update all of the dependencies, OM is tested with the versions that come in your composer.lock.

@fballiano
Copy link
Contributor

we can't do anything about this I think, you can still update your dependencies (eg: if you install some OM modules via composer, that's totally possible)

@fballiano fballiano closed this as not planned Won't fix, can't repro, duplicate, stale Aug 17, 2023
@twosg
Copy link
Author

twosg commented Aug 17, 2023

It's not a problem, I simply use "shardj/zf1-future": "1.22.0" in my composer.json now.

I did not have it directly required in my composer.json before, so I just wanted to mention that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants