Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Secrets are not passed to github action workflows that are triggered by a pull request from a fork #367

Open
larainema opened this issue Oct 10, 2020 · 5 comments

Comments

@larainema
Copy link
Contributor

@mfriesenegger @jmertic
We have do some investigates, but didn't find a good solution for this issue, need some help and discuss from team and linux foundation.
This block the github action to access the Vicom infinity Z infrastructure.

@jmertic
Copy link
Member

jmertic commented Oct 11, 2020

@pono Any ideas here?

@larainema
Copy link
Contributor Author

We have proposed one solution:

  1. if a pull request from forked repo branch
  2. create a local branch from this forked repo branch (might need permission to create local branch)
  3. then create a new pull request from the local branch to get the secret

This is the proposal, not test yet, any comments?

@jichenjc
Copy link
Collaborator

@larainema any thing need help from @jmetric?I think we need only inform what's need from us and later on with that we can perform the test..

@mfriesenegger
Copy link
Contributor

@larainema I am on the monthly OMP Technical Advisory Council call and it was mentioned by @jmertic that there is a solution so the secrets work properly with GitHub Actions workflows. Do you know this and have you had a chance to try the solution?

@larainema
Copy link
Contributor Author

@larainema I am on the monthly OMP Technical Advisory Council call and it was mentioned by @jmertic that there is a solution so the secrets work properly with GitHub Actions workflows. Do you know this and have you had a chance to try the solution?

@mfriesenegger yes, @jmertic mentioned in the slack that pull_request_target event trigger might works, we plan to try this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants