Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsigned routes should not be included in the transportation_name layer #1613

Open
Blijbol opened this issue Jan 15, 2024 · 3 comments
Open

Comments

@Blijbol
Copy link

Blijbol commented Jan 15, 2024

The transportation_name layer is intended for labelling highways. However, routes are currently included in this layer even if they are explicitly tagged with unsigned=yes.

For example, I 375 Business Spur (Detroit, MI) is currently rendered by OpenMapTiles:

Schermafdruk van 2024-01-15 23-11-25

For the vast majority of non-expert use-cases, maps will be better if they do not show unsigned routes. I therefore suggest to exclude routes with unsigned=yes from the transportation_name layer.

@reventlov123
Copy link

reventlov123 commented Jan 16, 2024

This is based (IMO) on the erroneous tagging of unsigned routes as "unsigned=yes". They should be tagged with "unsigned_ref". Tagging as "unsigned" in the given example would imply that there is not only no signage for the highway designation, but no signage for the "street name" (which presumably is not the case).

It would seem better to simply fix the erroneous tagging.

@Blijbol
Copy link
Author

Blijbol commented Jan 16, 2024

Tagging as "unsigned" in the given example would imply that there is not only no signage for the highway designation, but no signage for the "street name" (which presumably is not the case).

I am talking about the tagging of the relation, not the tagging of the way. Tagging unsigned=yes on the route relation for the I 375 Business Spur simply indicates that the I 375 Business Spur is unsigned. The street name (East Jefferson Avenue) comes from the highway way and has nothing to do with the route relation.

@reventlov123
Copy link

reventlov123 commented Jan 18, 2024

Apparently I misunderstood the example you gave... after "driving" it on street view, I now get that there are actually no signs for the route whatsoever... it's not a "virtual congruency" but a "virtual highway". The "highway" signs along it are all directional ("to" whatever).

It still seems relevant, though, that the physical feature that is actually being mapped (the road) does itself have signs, they just don't show the highway designation... I think that's the specific point that unsigned_ref is meant to capture. TBH using "unsigned=yes" on a relation that has members that do have signs (even if they say something else) seems a bit too abstract, when you can use "unsigned_ref" to point at the specific trait that isn't marked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants