Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce POIs from zoom 12 #387

Open
nlehuby opened this issue Dec 12, 2017 · 5 comments
Open

Introduce POIs from zoom 12 #387

nlehuby opened this issue Dec 12, 2017 · 5 comments

Comments

@nlehuby
Copy link
Member

nlehuby commented Dec 12, 2017

For now, the POI layer is quite on/off : nothing (except transport items) util z14, then, many POIs.
It would be great to add a few important POIs from z12, to allow a progressive display.
For instance, in Paris, we could have the Eiffel Tower, the Cathedral of Notre Dame de Paris and the Louvre museum at z12.

We could use wikidata and/or wikipedia to select important POIs :

I've tried wikidata P1174 method and wikipedia page views method, by hand, in Paris, and both provide good results.

What do you think ?

@jirik
Copy link
Collaborator

jirik commented Jan 17, 2018

+1 for adding important POIs at Z12+. We already started with railway stations and ferry terminals.

The thing is: How to decide what is important? Currently we use ranking computed by poi_class_rank. It's really not perfect, as it is based only on class of the POI.

We can combine the class-based rating with some other kind of ranking (e.g. popularity). An approach similar to current approach:

  • assign class rank CR in range 1..N
  • compute popularity rank PR in range 0..9
  • compute total rank as rank=CR*10+PR

It's just a suggestion open to discussion.

Anyway, it would be good also to improve current class-based ranking, e.g. to rank transportation-related POIs with higher ranks. By the way, by adding amenity=doctors to hospital class, we increased popularity of doctor's offices much more than it should be.

@jirik jirik added this to the v3.9 milestone Jan 17, 2018
@nlehuby
Copy link
Member Author

nlehuby commented Jan 19, 2018

My thinking was to compute the class rank and the popularity rank, and add them as is in the tiles to let each style designer define its own POI ponderation according to its needs.
But your proposal seems fine too.

Do you have any preconisation to create the popularity rank ?
If not, we may begin with the wikidata property because it's simpler (as we already have a wikidata import)

Do you want me to remove the doctors from the hospital class ? I'm the one to blame about this, and I agree, the doctors office are now quite over-ranked.

jirik added a commit that referenced this issue Jan 29, 2018
@jirik
Copy link
Collaborator

jirik commented Jan 29, 2018

@nlehuby I would prefer to use one rank now, since it's closer to current state. Two ranks is interesting option for OMT 4.0.

I am afraid we do not have any preconisation, so please try what you think is the best option.

I have just remove the doctors, so it should be fixed: d48b623

antoine-de pushed a commit to antoine-de/openmaptiles that referenced this issue Jul 12, 2018
antoine-de pushed a commit to antoine-de/openmaptiles that referenced this issue Jul 12, 2018
@klokan klokan modified the milestones: v3.9, v3.10 Nov 5, 2018
@daliborjanak daliborjanak removed this from the v3.10 milestone Oct 25, 2019
@RilusMahmud
Copy link

Where and how is poi ranking defined? and can we change or modify the ranking as per our need?

@TomPohys
Copy link
Member

Hi @RilusMahmud, POIs are ranked based on class https://github.com/openmaptiles/openmaptiles/blob/master/layers/poi/class.sql and if they have name https://github.com/openmaptiles/openmaptiles/blob/master/layers/poi/layer.sql#L45

For personal modification, please use Fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants