Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path, footway, cycleway ambiguity #422

Closed
chen-ye opened this issue Feb 3, 2018 · 4 comments · Fixed by #604
Closed

path, footway, cycleway ambiguity #422

chen-ye opened this issue Feb 3, 2018 · 4 comments · Fixed by #604
Milestone

Comments

@chen-ye
Copy link

chen-ye commented Feb 3, 2018

There's still a lot of ambiguity in OSM about how different kinds of paths should be coded (see: https://wiki.openstreetmap.org/wiki/Path_controversy).

There's also a wide variety of features coded as "paths" that should probably be differentiated from each other, especially on non-automotive maps (maps for cycling, hiking, etc): https://wiki.openstreetmap.org/wiki/Path_examples.

To differentiate these, could OMT include the bicycle/foot/horse and surface: tags from OSM?

@klokan
Copy link
Member

klokan commented Feb 22, 2018

Yes it could - make a proposal for modification of the schema please.

@Phyks
Copy link
Contributor

Phyks commented Jan 1, 2019

Hi,

I am interested in this issue as well, and this would likely solve #512.

Concerning the surface, I would add a surface field to the transportation layer. I can make a PR for this.

Is adding the bicycle/foot/horse fields as well fine? I guess these should be added only on path highways?

Thanks

@MartinMikita
Copy link
Collaborator

Hello @Phyks,

Yes, you can add a new attribute surface to distinguish these types in the transportation layer. Bicycle, foot, horse should be enough for now.

Please, prepare a PR, and we would appreciate, if you could compare what would be the final effect - the size of MBTiles, size of the database, time of importing and rendering (before and after your change).
You could start with smaller states like Albania, and probably prepare and compare the results on Switzerland or Czech Republic, these have a lot of bicycle ways.

This could help us to decide if we would include it in the official OpenMapTiles scheme in the next release (v3.10).

@MartinMikita MartinMikita added this to the v3.10 milestone Jan 3, 2019
Phyks added a commit to Phyks/openmaptiles that referenced this issue Jan 9, 2019
Keep surface field from OSM on highways, generalize it to two values:
"paved" and "unpaved".

This is a fix for openmaptiles#389 and a partial fix for openmaptiles#422.
Phyks added a commit to Phyks/openmaptiles that referenced this issue Jan 11, 2019
@zstadler
Copy link
Contributor

zstadler commented Apr 5, 2019

The approach for handling bicycle = designated implemented in #573 is different than the approach requested in issue #512.

As @nnhubbard noted, the different values of the bicycle tag should be preserved so they can be styled differently if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants