Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Totally remove mapbox-studio-classic #505

Closed
typebrook opened this issue Oct 7, 2018 · 3 comments
Closed

Totally remove mapbox-studio-classic #505

typebrook opened this issue Oct 7, 2018 · 3 comments

Comments

@typebrook
Copy link
Contributor

typebrook commented Oct 7, 2018

@jirik @klokan @MartinMikita @lukasmartinelli
I want to totally remove mapbox-studio-classic from openmaptiles.
Please give me some feedback! Thanks!

Since travis build for mapbox/mapbox-studio-classic keeps failing from 9 months ago, I think there is no evidence that this project is alive/backed by Mapbox.

ref:
Travis build history: https://travis-ci.org/mapbox/mapbox-studio-classic/builds
related issue : mapbox/mapbox-studio-classic#1581

The latest PR about mapbox-studio-classic is #304 (tiny part of quickstart refactoring #261 )
But since the author stopped working on it for 9 month, and original intend is moving it to Makefile, I think it's OK to just make another tiny commit on master branch.

by the way, it is a little scary that master branch stopped at 👹 666 commits over 2 months. if experienced contributors think it is OK, I will quickly make a simple PR for this.

@MartinMikita
Copy link
Collaborator

Hi @typebrook,

You can prepare a PR with a removal of mapbox-studio-classic, or you can try to find a way to get it working.

Well, there were no required changes, and we are still looking for enthusiastic contributors ;)

@typebrook
Copy link
Contributor Author

typebrook commented Oct 8, 2018

@MartinMikita Thanks for your reply, PR made #506
Removal is simple, but I think more important things is the necessity evaluation for this move.
I don't have any experience about this classic version, but it just annoyed me by failing on it's docker running.

Any Mapbox worker/experienced user here? Do we still need this thing?

@typebrook
Copy link
Contributor Author

#506
Close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants