Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickstart refactoring #261 #304

Closed
wants to merge 4 commits into from
Closed

Conversation

ImreSamu
Copy link
Collaborator

@ImreSamu ImreSamu commented Jul 6, 2017

First part of #261

quick refactoring

  • Moving 'osm2vectortiles/mapbox-studio ' definitions from the docker-compose.yml to the Makefile,
    • this part is needs more testing! if the users complaining - we need to restore this part.
  • nohup quickstart.sh support generate-vectortiles fails #166
  • removing current quickstart warnings. ( quick fix )
The MIN_ZOOM variable is not set. Defaulting to a blank string.
The MAX_ZOOM variable is not set. Defaulting to a blank string.
  • add generate-devdoc to travis check ( maybe this is help to detect warnings! )

example:

docker-compose run -T --rm openmaptiles-tools generate-etlgraph layers/landcover/landcover.yaml						./build/devdoc
Warning: node layer_landcover, port z5_6 unrecognized
Warning: node layer_landcover, port z7 unrecognized
Warning: node layer_landcover, port z5_6 unrecognized
Warning: node layer_landcover, port z7 unrecognized

@jirik jirik self-requested a review July 14, 2017 13:27
@jirik
Copy link
Collaborator

jirik commented Jan 16, 2018

@ImreSamu Will you continue with this PR? It states "First part of #261", so I expected that you will extend it, but nothing happens in last 6 months.

@ImreSamu
Copy link
Collaborator Author

ImreSamu commented Jan 16, 2018

Will you continue with this PR?

Probably I have not enough capacity in the next month, so you can adapt, continue, close - as you like,
sorry,

@jirik
Copy link
Collaborator

jirik commented Jan 16, 2018

Thanks for reply, I will try to look at it prior to 3.8.

@jirik jirik self-assigned this Jan 16, 2018
@jirik jirik added this to the v3.8 milestone Jan 16, 2018
@jirik jirik modified the milestones: v3.8, v3.9 Apr 16, 2018
@klokan klokan removed the request for review from jirik November 5, 2018 07:45
@klokan klokan unassigned jirik Nov 5, 2018
@klokan klokan modified the milestones: v3.9, Later Nov 5, 2018
@klokan
Copy link
Member

klokan commented Nov 10, 2019

This is very old work - not touched by anybody for almost two years. Closing.

@klokan klokan closed this Nov 10, 2019
@nyurik
Copy link
Member

nyurik commented Nov 10, 2019

Agree, and besides, we should probably upgrade to the newest tools first before doing any quickstart cleanup.

@nyurik nyurik deleted the quickstart_refactor_201707 branch May 4, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants