Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tram stops #52

Closed
pnorman opened this issue Nov 22, 2016 · 9 comments
Closed

Add tram stops #52

pnorman opened this issue Nov 22, 2016 · 9 comments
Labels
Milestone

Comments

@pnorman
Copy link
Collaborator

pnorman commented Nov 22, 2016

railway=tram_stop

I'm inclined to think this should go with highway=bus_stop into its own layer.

@lukasmartinelli
Copy link
Contributor

railway=tram_stop

I'm inclined to think this should go with highway=bus_stop into its own layer.

A transport_poi/transport_stop layer?
We can also include them in poi for now.

@pnorman
Copy link
Collaborator Author

pnorman commented Jan 14, 2017

Any decisions on this?

I'm inclined towards having one field for transit mode and another for station vs stop. You've got both bus station / bus stop and railway station / railway halt.

@lukasmartinelli
Copy link
Contributor

Any decisions on this?

I'm inclined towards having one field for transit mode and another for station vs stop. You've got both bus station / bus stop and railway station / railway halt.

Do you favor a field over a separate transport layer?
For me either way is good. The poi layer as of right now is really not refined at all. The next implementation of the poi layers can adjust to your proposed schema. I have no hard opinions here.

@stirringhalo
Copy link
Collaborator

I think it should be a separate layer as the stops get can rather numerous in cities, and I can see that many would not find it strictly necessary for their uses.

@pnorman
Copy link
Collaborator Author

pnorman commented Jan 17, 2017

Do you favor a field over a separate transport layer?

A separate layer for each mode?

transport_stop is an okay name, but I like transit_stop better because we're dealing with just transit stuff, not stuff like stop signs.

I think it should be a separate layer as the stops get can rather numerous in cities, and I can see that many would not find it strictly necessary for their uses.

Although I support adding a layer, I don't find data density a reason to do so.

@pnorman
Copy link
Collaborator Author

pnorman commented Jan 17, 2017

Just to note, the mods that I have are

  • ferry
  • rail
  • taxi
  • bus

I intend to add subway ClearTables/ClearTables#101 but need to work out some issues first

@lukasmartinelli
Copy link
Contributor

Can you list the new fields and the possible values like you did for the other layers so I can add them to the docs?

So transit_stop= on of ferry, rail, taxi, bus ?

BTW. is there already an endpoint for the Wikimedia tiles?

@pnorman
Copy link
Collaborator Author

pnorman commented Jan 17, 2017

fields

  • mode (text) The mode of transportation. Values are ferry, rail, taxi, bus, and subway (not implemented by me yet)
  • station (boolean) If the feature is a larger station or a small stop.

Within ClearTables I'm calling the mode of transportation "transit_mode" to avoid name collisions with the "mode" function when writing queries.

BTW. is there already an endpoint for the Wikimedia tiles?

The best bet is to poke me in #wikimedia-interactive on irc.freenode.net. There is a dev instance running Kosmtik with the tiles on a wmflabs machine, but Kosmtik gets shut down and restarted fairly regularly.

@stirringhalo stirringhalo added this to the Later milestone Jun 24, 2017
@jirik jirik modified the milestones: Later, v3.8 Jan 16, 2018
@jirik
Copy link
Collaborator

jirik commented Jan 16, 2018

Most of this issue was already implemented in 3.7:

  • tram_stop as class=railway, subclass=tram_stop
  • subway as class=railway, subclass=subway
  • ferry as class=ferry_terminal
  • bus as class=bus, subclass IN (bus_stop, bus_station)
  • taxi as class=car, subclass=taxi

For the next major release of OMT (4.0) it probably makes sense to create separate stop for stations and stops.

@jirik jirik closed this as completed Jan 16, 2018
@jirik jirik modified the milestones: v3.8, v3.7 Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants