Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waterway:dock is showing up as land #526

Closed
klokan opened this issue Nov 7, 2018 · 5 comments
Closed

Waterway:dock is showing up as land #526

klokan opened this issue Nov 7, 2018 · 5 comments
Assignees
Milestone

Comments

@klokan
Copy link
Member

klokan commented Nov 7, 2018

From: https://www.maptiler.com/how-to/forum/?place=msg%2Fmaptiler%2Fl1ze-S1tgDY%2F71P-1HIiBQAJ

Waterway:dock is showing up as land on maptiler maps.

I tried to add style to make it same as water. However, the layer doesn't show up.

On openstreetmap the Royal Dock in Grimsby is water, but not on MapTiler:
https://www.openstreetmap.org/#map=15/53.5793/-0.0716

Here's my style:

{
  "id": "waterway_dock",
  "type": "fill",
  "metadata": {},
  "source": "openmaptiles",
  "source-layer": "waterway",
  "filter": [
    "all",
    [
      "==",
      "class",
      "dock"
    ]
  ],
  "layout": {},
  "paint": {
    "fill-color": "rgba(232, 20, 20, 1)"
  }
}

https://www.maptiler.com/maps/#streets//vector/15/-0.0716/53.5793
https://openmaptiles.org/inspect/#15/53.5793/-0.0716

@klokan
Copy link
Member Author

klokan commented Nov 7, 2018

Probably related to #522 - but here we need to join with the water? @jirik

@klokan
Copy link
Member Author

klokan commented Nov 7, 2018

Could be probably also solved by modification of the data in OSM in this individual case... but the question is whether there are similar data issues elsewhere...

@anajavi
Copy link

anajavi commented Nov 7, 2018

@jirik jirik added this to the v3.9 milestone Nov 11, 2018
@jirik
Copy link
Collaborator

jirik commented Nov 11, 2018

It's not related to #522 . The reason is simple: OMT do not import waterway:dock items to DB water tables, so they are not encoded into mbtiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants