Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generating disputed_name for NE data source of borders #964

Closed
eva-j opened this issue Aug 18, 2020 · 0 comments · Fixed by #976
Closed

Generating disputed_name for NE data source of borders #964

eva-j opened this issue Aug 18, 2020 · 0 comments · Fixed by #976
Assignees
@eva-j
Milestone
v3.12

Comments

@eva-j
Copy link
Collaborator

eva-j commented Aug 18, 2020 •
edited

For now NULL AS disputed_name, NULL AS claimed_by is defined for all the NE inputs of boundary layer.
https://github.com/openmaptiles/openmaptiles/blob/master/layers/boundary/boundary.sql#L221

I suggest to use ogc_fid to make disputed_name filled (something like: "ne110m_" + ogc_fid, "ne50m_" + ogc_fid, "ne10m_" + ogc_fid), then it is possible to filter in style. There is no better info to distinguish the lines.

Screenshot from 2020-08-18 16-54-40
@eva-j eva-j self-assigned this Aug 18, 2020
@eva-j eva-j added this to the v3.12 milestone Aug 18, 2020
@eva-j eva-j mentioned this issue Sep 2, 2020
Merged
@TomPohys TomPohys linked a pull request Sep 3, 2020 that will close this issue
Adding disputed_name to NE sources #976
Merged
TomPohys pushed a commit that referenced this issue Sep 3, 2020
@eva-j
adding disputed_name to NE sources (#976)
1356d72 
`disputed_name` is filled for disputed lines of NaturalEarth sources - it contains `ogc_fid` as suggested in #964. This way it is possible to filter disputed lines in style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eva-j eva-j

Labels
None yet
Projects
None yet
Milestone
v3.12
Development

Successfully merging a pull request may close this issue.

Adding disputed_name to NE sources eva-j/openmaptiles
1 participant
@eva-j