New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused network type params #1155
Merged
TomPohys
merged 3 commits into
openmaptiles:master
from
ZeLonewolf:unused-network-type-params
Jul 26, 2021
Merged
Remove unused network type params #1155
TomPohys
merged 3 commits into
openmaptiles:master
from
ZeLonewolf:unused-network-type-params
Jul 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Results evaluating commit 205bd13 (merged with base 951aa90 as f1da555). See run details. PostgreSQL DB size in MB: 2786 ⇒ 2786 (0.0% change)
expand for details...
|
ZeLonewolf
force-pushed
the
unused-network-type-params
branch
from
July 24, 2021 18:07
49b6fb7
to
5c1be79
Compare
TomPohys
approved these changes
Jul 26, 2021
Thanks for the clean-up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in #1143 removed the need for
name
andref
parameters in the network-to-network_type conversion function. This PR removes this dead code.Verified by running ./quickstart rhode-island which completed successfully.