New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Water layer river mapping bug fixes #1182
Conversation
Results evaluating commit 49ede62 (merged with base 1cea73c as ddfa6ba). See run details. PostgreSQL DB size in MB: 2791 ⇒ 2792 (0.0% change)
expand for details...
|
Thanks @ZeLonewolf for this PR, it looks good, but I need to do some local tests. |
Results evaluating commit 6a7d0f6 (merged with base 0e17d53 as 8fdb054). See run details. PostgreSQL DB size in MB: 2792 ⇒ 2792 (0.0% change)
expand for details...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this fix, it works good.
This PR is a bugfix for the
water
layer.waterway=stream
,waterway=river
,waterway=canal
,waterway=ditch
, andwaterway=drain
are all linear features, not area features. Thus, these objects are being unnecessarily mapped into theosm_water_polygon
polygon table, and this PR removes these unneeded mappings.natural=water
+water=river
is the most popular tagging for river areas. However, the current mapping causes rivers tagged in this way to be rendered in the vector tiles as alake
. This PR adds a check for thewater=river
tag and tags both variants of river areas asclass=river
.natural=water
+water=river
river mapping:waterway=riverbank
river mapping:Lake mapping for a
natural=water
(with no other tagging):