Check if bc command is available #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomPohys
approved these changes
Aug 30, 2021
|
Thank you, it looks good! |
nyurik
reviewed
Sep 1, 2021
| echo " : --- Memory, CPU info ---- " | ||
| mem=$( grep MemTotal /proc/meminfo | awk '{print $2}' | xargs -I {} echo "scale=4; {}/1024^2" | bc ) | ||
| echo "System memory (GB): ${mem}" | ||
| if [ -n "$(command -v bc)" ]; then |
There was a problem hiding this comment.
thx, i have always used which, but i guess command is a more recommended way? (saw a comment about it, but don't have an authoritative source). Either works. Why do you use -v though?
There was a problem hiding this comment.
I don't know which of the commands would be better. I don't know which and i get command -v from an stackoverflow answer.
But i can verfiy that -v is good because it displays only the path of the program or blank. Without -v it displays an explanation of the program, which needs more time to display and it can happen that a program has no description, so it would be return blank too.
|
Results evaluating commit b68f70a (merged with base d205f4a as a19dfc8). See run details. PostgreSQL DB size in MB: 2792 ⇒ 2791 (-0.0% change)
expand for details... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems the
bccommand is not installed, so I added a check if the command can be used.It is a simply calculation from KB to GB. If
bcis missing, then it is displayed in KB.fix: #1151